Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use simultaneously compilation #342

Closed
wants to merge 3 commits into from

Conversation

andreivladbrg
Copy link
Member

Closes #341

Changes

build: remove no longer needed optimized profiles
build: update shell scripts
test: remove no longer needed Utils functions
test: use the interfaces in Base_Test instead of the contracts
chore: update precompiles bytecode
chore: update scripts in package.json
ci: update ci workflows to pass the default profile

build: remove no longer needed optimized profiles
build: update shell scripts
test: remove no longer needed Utils functions
test: use the interfaces in Base_Test instead of the contracts
chore: update precompiles bytecode
chore: update scripts in package.json
ci: update ci workflows to pass the default profile
@andreivladbrg
Copy link
Member Author

it looks like we need to update the reusable workflows repo, and to synchronize all repos merges

https://github.com/sablier-labs/reusable-workflows/blob/dfca031493cfa2e579610e3a871ca93465b2968a/.github/workflows/forge-build.yml#L44-L48

@andreivladbrg andreivladbrg force-pushed the build/additional-compiler-profiles branch from a5043ba to 637c870 Compare December 3, 2024 19:10
@andreivladbrg
Copy link
Member Author

andreivladbrg commented Dec 4, 2024

@smol-ninja, as discussed on Slack, I am going to close this PR for now (but I will keep the branch) since there isn't an immediate fix for the issue:

image

I tested it myself on Ubuntu and Windows, and it doesn't seem to work due to the parallel compilation of too many contracts (both with via_ir and without via_ir for the tests). This appears to be related to memory handling at the OS level. We will keep the optimize profiles for now.

@PaulRBerg
Copy link
Member

@andreivladbrg can you please share feedback in the official Foundry repository

@andreivladbrg
Copy link
Member Author

will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of "optimized" foundry profiles
2 participants